[Ur] Several patches and questions

Adam Chlipala adamc at csail.mit.edu
Fri Nov 30 10:04:03 EST 2012


On 11/28/2012 02:45 PM, Austin Seipp wrote:
> On 11/18/2012 06:08 PM, Austin Seipp wrote:
>>> Attached are some patches. In order:
>>>
>>> 1.) Add a 'username' tag, mostly to match 'password'. I wanted to have
>>> a nice bootstrap-style login, but it wants the type attribute to be
>>> 'text' for the login and 'password' for the pass, and there's no way
>>> to specify the type for the attribute (you could theme this with CSS
>>> or something, but this is just the out of the box config for bootstrap
>>> it seems.) So this just specifies type="text" - This patch also adds
>>> 'placeholder' attributes to 'username' and 'password' to match
>>> 'textbox.'
>>>
>>>        
>> What would you think about instead making the compiler include 'type="text"'
>> with every<textbox>  tag?  For this one especially, I'm interested in
>> others' opinions, too.
>>      
> I have no particular opinion here, although it sounds completely
> sensible to me. Definitely up for outside thoughts.
>    

Since no one else weighed in yet, I went ahead and changed code 
generation to include 'type="text"', and I combined this in a changeset 
with adding the 'placeholder' attribute to <password>, as in your 
original patch.



More information about the Ur mailing list