[Ur] more small patches: elisp, fieldset, file

Julian Squires julian at cipht.net
Mon May 4 15:00:48 EDT 2015


Hi,

Attached are five minor patches.

The most useful one fixes a couple of major irritations for me in the
emacs mode with regards the indentation of XML.  I have only tested it
on emacs 25 so far, though, so feedback on its validity on earlier
versions of emacs would be appreciated.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: el-xml-indent.patch
Type: text/x-diff
Size: 1932 bytes
Desc: not available
URL: <http://www.impredicative.com/pipermail/ur/attachments/20150504/da1c87e6/attachment.patch>
-------------- next part --------------

The second adds an urweb-close-matching-tag command to the emacs mode.
This is a small convenience inspired by nxml-mode's nxml-finish-element,
with the same binding (C-c /).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: el-close-matching-tag.patch
Type: text/x-diff
Size: 1277 bytes
Desc: not available
URL: <http://www.impredicative.com/pipermail/ur/attachments/20150504/da1c87e6/attachment-0001.patch>
-------------- next part --------------

The third adds the "style" keyword as starting an expression in the emacs
mode.  Otherwise, any style following another expression will be
indented incorrectly.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: el-style.patch
Type: text/x-diff
Size: 873 bytes
Desc: not available
URL: <http://www.impredicative.com/pipermail/ur/attachments/20150504/da1c87e6/attachment-0002.patch>
-------------- next part --------------

Hopefully I will have the chance to fix the indentation of table
constraints soon.

The fourth patch attached adds the <fieldset> and <legend> tags, in the
most trivial way.  This was enough for my needs so far, but I'm already
realizing that this is probably not sufficient -- at the very least,
fieldset needs to support the disabled attribute.  I'm attaching it
anyway to open discussion about it.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-fieldset-and-legend.patch
Type: text/x-diff
Size: 613 bytes
Desc: not available
URL: <http://www.impredicative.com/pipermail/ur/attachments/20150504/da1c87e6/attachment-0003.patch>
-------------- next part --------------

Finally, it seems to me that any URI specified by a "file" directive is
implicitly one that one intends to "allow".  The last patch does this.
I can see how my assumption here might be contrary to the Ur/Web Way,
though.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: allow-files.patch
Type: text/x-diff
Size: 1397 bytes
Desc: not available
URL: <http://www.impredicative.com/pipermail/ur/attachments/20150504/da1c87e6/attachment-0004.patch>
-------------- next part --------------

I'll try to avoid grouping unrelated patches together in future emails
to the list; I just wanted to avoid spamming the list with messages for
such small patches.

Thanks,

--
Julian Squires


More information about the Ur mailing list